Skip to content

Amend 7500 - deprecate whitelisted_users API argument #7524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Amend 7500 - deprecate whitelisted_users API argument #7524

wants to merge 6 commits into from

Conversation

pavoljuhas
Copy link
Collaborator

  • Regenerates QuantumEngineService gRPC client libraries with GAPIC
  • Remove gapic_version.py everywhere and subistute cirq_google.version where needed
  • Deprecate whitelisted_users in the AbstractLocalProcessor class
  • Deprecate whitelisted_users in the EngineClient class
  • Deprecate whitelisted_users in the EngineProcessor class

hoisinberg and others added 5 commits July 18, 2025 11:05
@hoisinberg
Regenerates QuantumEngineService gRPC client libraries with GAPIC
df98f15
@hoisinberg
Remove gapic_version.py everywhere and subistute cirq_google.__versio…
99b7452 
…n__ where needed
@pavoljuhas
Deprecate whitelisted_users in the AbstractLocalProcessor class
c865fa9 
Add deprecation warning to `create_reservation` and `update_reservation`.
@pavoljuhas
Deprecate whitelisted_users in the EngineClient class
8b68596 
Add deprecation warning to `create_reservation_async` and
`update_reservation_async`.
@pavoljuhas
Deprecate whitelisted_users in the EngineProcessor class
79da477 
Add deprecation warning to `create_reservation` and `update_reservation`.
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the size: XL lines changed >1000 label Jul 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.30570% with 412 lines in your changes missing coverage. Please review.

Project coverage is 97.53%. Comparing base (731f1bf) to head (b28e9aa).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ces/quantum_engine_service/transports/rest_base.py 47.79% 249 Missing ⚠️
...v1alpha1/services/quantum_engine_service/pagers.py 6.49% 72 Missing ⚠️
.../quantum_engine_service/transports/grpc_asyncio.py 29.50% 43 Missing ⚠️
...services/quantum_engine_service/transports/grpc.py 27.77% 39 Missing ⚠️
...services/quantum_engine_service/transports/base.py 59.09% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7524      +/-   ##
==========================================
- Coverage   98.68%   97.53%   -1.15%     
==========================================
  Files        1091     1095       +4     
  Lines       96863    98934    +2071     
==========================================
+ Hits        95589    96497     +908     
- Misses       1274     2437    +1163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas
Copy link
Collaborator Author

this was for CI test only. superseded by #7500.

@pavoljuhas pavoljuhas closed this Jul 22, 2025
@pavoljuhas pavoljuhas deleted the amend-7500 branch July 22, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney will be requested when the pull request is marked ready for review wcourtney is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole will be requested when the pull request is marked ready for review vtomole is a code owner

@verult verult Awaiting requested review from verult verult will be requested when the pull request is marked ready for review verult is a code owner

Assignees
No one assigned
Labels
size: XL lines changed >1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavoljuhas @hoisinberg